Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pitest dependencies only during configuration resolution; resolves #302 #313

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

omalleyian
Copy link
Contributor

Changes the adding of dependencies to the pitest configuration to use the withDependencies method, and moves the addition of dependencies to occur during plugin configuration instead of task configuration.

I ran into the same error reported by #302 when using the VSCode vscode-gradle extension (3.10.0+), and I believe that the issue is caused by the pitest configuration (probably all configurations) being resolved during the project configuration phase - before this plugins' tasks add their dependencies. The intent of my changes are to wrap this plugin's dependency additions in a configuration action that will be executed whenever the pitest configuration is resolved - whether by the pitest task or some other reason (vscode-gradle plugin or project-report).

Fixes the issue when using both the project-report plugin and the VSCode vscode-gradle extension.

@omalleyian omalleyian changed the title Add pitest dependencies only during configuration resolution #302 Add pitest dependencies only during configuration resolution; resolves #302 Jun 28, 2022
@szpak szpak merged commit b4028af into szpak:master Jun 29, 2022
@szpak
Copy link
Owner

szpak commented Jun 29, 2022

Looks good. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants