Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relativepath for file inputs so that task inputs are relocatable #315

Closed
wants to merge 1 commit into from

Conversation

SidB3
Copy link
Contributor

@SidB3 SidB3 commented Aug 4, 2022

closes #314

@SidB3 SidB3 changed the title Use relativepath for file inputs Use relativepath for file inputs so that task inputs are relocatable Aug 4, 2022
@SidB3
Copy link
Contributor Author

SidB3 commented Aug 8, 2022

@szpak - A gentle reminder on the PR. Thanks!

@szpak
Copy link
Owner

szpak commented Aug 8, 2022

Thanks. Relative paths here seem much more sensible. I'm not sure why the Travis checks didn't kick in :-/. I plan to merge it into devel to test it on CI and probably apply some other pending changes before releasing the new version.

@szpak
Copy link
Owner

szpak commented Aug 8, 2022

It would be good to have some function test, but I'm not sure how TestKit deals with sharing the build cache (across tests and with the regular builds), so let's skip it.

szpak pushed a commit that referenced this pull request Aug 8, 2022
szpak added a commit that referenced this pull request Aug 8, 2022
@szpak
Copy link
Owner

szpak commented Aug 8, 2022

Btw2, those inputs shouldn't be just String, however, in the times I started this plugin other fancy types were not available... I have to find out how much backward incompatible it would be to "enhance" them.

@SidB3
Copy link
Contributor Author

SidB3 commented Aug 16, 2022

Hi @szpak how's the testing going with this change? Any tentative timelines for putting out a new release?

@szpak szpak added this to the 1.7.5 milestone Aug 19, 2022
@szpak
Copy link
Owner

szpak commented Aug 19, 2022

@SidB3 There were some issues with the other changes in the plugin, but today I managed to merge it (manually) and released 1.9.0. Thanks for your contribution!

@szpak szpak closed this Aug 19, 2022
@SidB3
Copy link
Contributor Author

SidB3 commented Aug 19, 2022

Thank you!

@SidB3 SidB3 deleted the relc branch August 20, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pitest build cache not working if the absolute path changes
2 participants