Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adb_stop_bit_srq_listen() and adb_wait_tlt() #1

Open
arpruss opened this issue Aug 17, 2022 · 2 comments
Open

adb_stop_bit_srq_listen() and adb_wait_tlt() #1

arpruss opened this issue Aug 17, 2022 · 2 comments

Comments

@arpruss
Copy link

arpruss commented Aug 17, 2022

Looking at the code, the two functions always return the same value.

@szymonlopaciuk
Copy link
Owner

You are right, also about #2. Sorry for the delay, I am a bit busy at the moment. Feel free to make a pull request as you see fit, or otherwise I will try to fix in at some point when I have more time.

@arpruss
Copy link
Author

arpruss commented Sep 2, 2022

It's too much work to make the pull request right now, as my own fork revises the code very heavily to make it work with the less bloated libmaple core (using my USBComposite library) and to use the CYCCNT debug register for accurate timing instead of calling delayMicroseconds(). At least on libmaple, and maybe on the official stm32 core, delayMicroseconds() is wrong on some stm32f103c8t6 clones. Also, I have found CYCCNT to be an excellent way to handle timing, as you can avoid worries about overhead. My fork is: https://github.com/arpruss/stm32-adb2usb/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants