Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Pattern.match() into match() and search() #133

Closed
danon opened this issue May 8, 2022 · 1 comment
Closed

Split Pattern.match() into match() and search() #133

danon opened this issue May 8, 2022 · 1 comment
Assignees
@danon
Labels
in progress

Comments

@danon
Copy link
Member

danon commented May 8, 2022

Currently match() sometimes behaves as it returns collection of Detail (findFirst(), first() callback, stream()) and sometimes as if it was working on string (all(), nth(), only(), first() without callback).

We should split it into:

  • match() which always deals and returns Detail
  • search() which always deals and returns string
@danon
Copy link
Member Author

danon commented May 8, 2022

Maybe use IteratorIterator for getIterator()?

danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
d53585f
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
4bd0065
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
927d3bf
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
67474ae
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
b706581
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
b94ba2e
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
86e1c39
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
7044920
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
bfa9b6a
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
b2f8ff5
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
ceb94e5
danon added a commit that referenced this issue Jun 1, 2022
@danon
Refactor Detail.groups() and Detail.namedGroups() #133
a3e7561
@danon danon self-assigned this Jun 1, 2022
danon added a commit that referenced this issue Jun 3, 2022
@danon
Remove GroupMatch #133
2cf6ff0
danon added a commit that referenced this issue Jun 3, 2022
@danon
first()/findFirst() don't accept consumer #133
1f03c66
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
3cdce3c
danon added a commit that referenced this issue Jun 6, 2022
@danon
Remove GroupMatch #133
bfe7b38
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
7f27903
danon added a commit that referenced this issue Jun 6, 2022
@danon
Remove GroupMatch #133
31b0851
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
f30b0fd
danon added a commit that referenced this issue Jun 6, 2022
@danon
Remove GroupMatch #133
c2e3845
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
0e64db0
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
4fede6c
danon added a commit that referenced this issue Jun 6, 2022
@danon
Remove GroupMatch #133
9fd3bff
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
1dcefbe
danon added a commit that referenced this issue Jun 6, 2022
@danon
Remove GroupMatch #133
f0ea50a
danon added a commit that referenced this issue Jun 6, 2022
@danon
first()/findFirst() don't accept consumer #133
1101473
danon added a commit that referenced this issue Jun 6, 2022
@danon
Remove GroupMatch #133
9a2c2f5
danon added a commit that referenced this issue Jun 14, 2022
@danon
Split matching to match() and stream() #133
f71f23c
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
dbb3ded
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
656da4c
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
61af20d
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
d2a0b7e
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
362f3f5
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
7864802
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
1e63974
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
6fbce4a
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
004c791
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
9045619
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
e4952f1
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
39c47ef
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
be7dd3b
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
f4872d3
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
2660e3c
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
61f0ce9
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
8bf22cb
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
1c5b8e3
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
c984872
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
7ed547e
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
ab917ea
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
c63737d
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
2caa6db
danon added a commit that referenced this issue Jun 15, 2022
@danon
Remove GroupMatch #133
9a12750
danon added a commit that referenced this issue Jun 15, 2022
@danon
first()/findFirst() don't accept consumer #133
f1bb76b
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
15b34dd
@danon danon closed this as completed Jun 15, 2022
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
2f71605
danon added a commit that referenced this issue Jun 15, 2022
@danon
Split matching to match() and stream() #133
a8d23eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danon danon

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danon