Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git tags to release versions #41

Closed
j3j5 opened this issue Feb 4, 2019 · 5 comments
Closed

Use git tags to release versions #41

j3j5 opened this issue Feb 4, 2019 · 5 comments

Comments

@j3j5
Copy link

j3j5 commented Feb 4, 2019

Hi, I just found out about this library, it looks really good, but I have a question. Is there a reason why you aren't locking releases with git tags?

@danon
Copy link
Member

danon commented Feb 4, 2019

Hey @j3j5 , thanks for writing! :) I'm glad you like the lib

I have a few more features to develop before version 1.0.0, and simultaneously I develop the documentation at http://t-regx.com.

But of course you're right, I guess i could use tags 0.7, 0.11, etc :) In fact, I'm gonna start using them now :)

@j3j5
Copy link
Author

j3j5 commented Feb 5, 2019

Awesome!! If I may, would you consider using semver? It is common practice and makes other people lives easier :)

Anyway, great work, you save my life yesterday on a battle to death I had against PREG_OFFSET_CAPTURE and multibyte strings. My head was about to explode till I tried you lib.

Thanks for the good work!

@j3j5 j3j5 changed the title Use the git tags to release versions Use git tags to release versions Feb 5, 2019
@danon
Copy link
Member

danon commented Feb 5, 2019

Didn't plan it, but I'll definitely use semver, it seams like consistency is a big thing in T-Regx :)

I'm very glad you liked it :D I'm proud to announce you're T-Regx's first user, hooray!

@j3j5
Copy link
Author

j3j5 commented May 27, 2019

I just saw the alpha release, I think we can close this issue!!

Congrats!!

@j3j5 j3j5 closed this as completed May 27, 2019
@danon
Copy link
Member

danon commented May 27, 2019

Oh my God, did you really keep an eye for my release? Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants