Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres schemas support #4

Merged
merged 13 commits into from Dec 27, 2021
Merged

Postgres schemas support #4

merged 13 commits into from Dec 27, 2021

Conversation

williamabreu
Copy link
Contributor

@williamabreu williamabreu commented Nov 17, 2021

๐Ÿ“ Description

This PR adds schema segregation support for Postgres databases, looking towards a microservices migration model.

๐Ÿ› ๏ธ Changes

  • Added schema on orm configuration (3b5e25d)
  • Removed useless root aggregate (a7f6ddf, 60a7b16)
  • Added legacy support to use without schemas (22dafea)

@williamabreu williamabreu changed the title WIP: Postgres schemas support Postgres schemas support Nov 17, 2021
Copy link

@andreyrcdias andreyrcdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to point out about the changes made here.

How would it work if I didn't want to use schema? would be public as default?

@williamabreu
Copy link
Contributor Author

@andreyrcdias I didn't set the default schema, nice suggestion!

@williamabreu
Copy link
Contributor Author

@andreyrcdias setting the default to public, it's necessary to use public schema prefix for all queries or foreign keys definitinos, such as is made for custom schemas names. In this way, I don't think setting the default public could be useful what do you think about it?

Copy link

@andreyrcdias andreyrcdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nice job @williamabreu ๐Ÿ‘Œ๐Ÿฝ

@williamabreu williamabreu merged commit 97bc0bf into main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants