Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): move Theme-toggle to Navbar #445

Closed
juliusmarminge opened this issue Sep 15, 2022 · 5 comments
Closed

feat(docs): move Theme-toggle to Navbar #445

juliusmarminge opened this issue Sep 15, 2022 · 5 comments
Labels
📚 documentation Improvements or additions to documentation 🌟 enhancement New feature or request

Comments

@juliusmarminge
Copy link
Member

Is your feature request related to a problem? Please describe.

The theme toggle is currently in the right sidebar when browsing docs, maybe we should move it to the navbar to be more standardized?

CleanShot 2022-09-15 at 09 54 25@2x

Describe the solution you'd like to see

Desribe alternate solutions

Additional information

No response

@juliusmarminge juliusmarminge added 🌟 enhancement New feature or request 📚 documentation Improvements or additions to documentation labels Sep 15, 2022
@nexxeln
Copy link
Member

nexxeln commented Sep 15, 2022

I kinda like it there its different.

@c-ehrlich
Copy link
Member

navbar would be better imo

@gabrielelpidio
Copy link
Collaborator

gabrielelpidio commented Sep 15, 2022

I made a PR that includes the change to check how it looks

@benmarg
Copy link
Contributor

benmarg commented Sep 15, 2022

navbar would be better imo

I think after seeing it in @gabrielelpidio PR, I'm of the mind it looks better in the Nav bar as well.

@juliusmarminge
Copy link
Member Author

it's in the navbar now, we can move it back if we don't like it. what do you think @nexxeln

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 🌟 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants