Packages fail to install

[nexxeln]

Describe the bug
After selecting packages to install it fails and shows this error

Aborting installation...
Error: ENOENT: no such file or directory, lstat 'template/base'

To Reproduce
Steps to reproduce the behavior:

1. npx create-t3-app@latest
2. Select any packages
3. See the error

Expected behavior
Packages should be installed

Screenshots

[klipitkas]

Can confirm, does the same for me.

[juliusmarminge]

is the constant PKG_ROOT accurate? it seems to be failing to copy over the base app when it scaffolds the project. not when it is installing the packages

EDIT: latest version on main branch (4.2.8) seems to work for me:
pnpm: https://app.warp.dev/block/75es65LAphP8aXQLUqrJZc
npm: https://app.warp.dev/block/KzdwQSg7VHIIMN7EvRsiPo

[nexxeln]

Thats interesting, works for you but not for me

[juliusmarminge]

I also have no issues running the CLI directly from npm store: https://app.warp.dev/block/H3HrXKP4E2yQtnfzflNLzd

EDIT: nvm running it when I'm not in the package directory fails: https://app.warp.dev/block/TapKvjoErC2CPtQlGHHhSV. even more reason to think the PKG_ROOT path is inaccurate

[devkevbot]

One very hacky solution: (seems to work for me, needs more testing)

import path from "path";
import { fileURLToPath } from "url";
import { dirname } from "path";
const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
// With the move to TSUP as a build tool, this keeps path routes in other files (installers, loaders, etc) in check more easily.
// Path is in relation to a single index.js file inside ./dist
export const PKG_ROOT = path.join(__dirname, "../");

[juliusmarminge]

how are you getting the error when running the build locally?

[devkevbot]

I also have no issues running the CLI directly from npm store: https://app.warp.dev/block/H3HrXKP4E2yQtnfzflNLzd

EDIT: nvm running it when I'm not in the package directory fails: https://app.warp.dev/block/TapKvjoErC2CPtQlGHHhSV. even more reason to think the PKG_ROOT path is inaccurate

Yes, the PKG_ROOT seems to be pointing at the place where someone is executing the npx command, not the actual package directory

[juliusmarminge]

should the template folder not ship with the CLI so that you don't have to do this hack and keep the paths as before?

[devkevbot]

should the template folder not ship with the CLI so that you don't have to do this hack and keep the paths as before?

Well, I don't really see how we can avoid shipping the template folder since those files need to be copied during scaffold and install.

[devkevbot]

how are you getting the error when running the build locally?

If you want to try to reproduce the error locally, you can install the package globally on your local machine and the try running npx create-t3-app, which should pick up that local install.

[juliusmarminge]

i don't have much knowledge about how shipping packages works, but in the dist folder, the template is not included, so I assume when running npx create-t3-app it doesn't have access to the template folder since it is not built?

[devkevbot]

i don't have much knowledge about how shipping packages works, but in the dist folder, the template is not included, so I assume when running npx create-t3-app it doesn't have access to the template folder since it is not built?

I'm not too experienced either, but here's the npm reference for which files get included: https://docs.npmjs.com/cli/v8/commands/npm-publish#files-included-in-package

[devkevbot]

Here's a summary of the problem as I understand it:

// The directory you are running npx create-t3-app in:
some/dir/

// The directory pointed to by the current version of PKG_ROOT:
some/

// The directory that the scaffolding step will look for:
some/template/base

Instead, we want the PKG_ROOT to point at the dirname of the package itself.

[juliusmarminge]

I believe that Kevins solution is good enough, and I can't seem to find any other way to get the path of the package itself.

Got a PR ready if you want me to submit it since Kevin logged off.

Have tested it and it seems reliable

[ghost]

If you need confirmation of this being an issue, I just tried to use it and had the same issue as @nexxeln

[nexxeln]

If you need confirmation of this being an issue, I just tried to use it and had the same issue as @nexxeln

Thank you for confirming