Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting tabWidth option in .prettierrc #87

Closed
devkevbot opened this issue Jul 3, 2022 · 2 comments · Fixed by #111
Closed

Consider setting tabWidth option in .prettierrc #87

devkevbot opened this issue Jul 3, 2022 · 2 comments · Fixed by #111
Labels
🌟 enhancement New feature or request

Comments

@devkevbot
Copy link
Contributor

devkevbot commented Jul 3, 2022

Is your feature request related to a problem? Please describe.

  • The project does not have a default tabWidth setting in the .prettierrc file, which appears to allow for a local user's indentation settings to override the in-place indentation when editing files.
  • This override behaviour is annoying when contributing because conveniences such as "format on save" will run using my editor's default settings (i.e. in VS Code) which causes other lines to be formatted even though I'm only change one line.

Describe the solution you'd like
I surmise that adding "tabWidth": <some preferred project value> (see configuration here) would alleviate this annoyance.

Describe alternatives you've considered
Alternative solutions would also include creating a .vscode folder in the project root and setting indentation there, but that would not affect users who contribute through Vim, Neovim, Sublime, etc.

@nexxeln nexxeln added the 🌟 enhancement New feature or request label Jul 4, 2022
@nexxeln
Copy link
Member

nexxeln commented Jul 4, 2022

Thank you, will add that soon.

@amar-jay
Copy link

amar-jay commented Jul 4, 2022

Done!!

This was referenced Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants