-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to have multiple HTML override packages #43
Comments
This is a good approach and if this can be adopted it would help tremendously. |
Currently, the core theme is put in folder "base" in the plugin. We should provide multiple core theme feature as an addon package of the plugin. IMO, the feature could be implemented as:
How do you think about this approach ? |
The issue is the template overrides. |
The framework provides only default base theme. Developers can provide their own base themes and declare to use it in template. Therefore, when upgrading framework, their work is not lost. |
I like this idea but I guess as soon as folks start adding their own overrides to the plugin then they are technically forking the plugin and potentially need to update each time the install an update for the plugin. There would be a way to not touch the new overrides when installing the plugin but seems better to move the override fiels outside of the plugin all together. Perhaps we could check the media folder for possible overrides? So these are just folders that get uploaded to media/t3/ and the plugin checks there before it checks the plugin? Perhaps the priority should be:
What do you think? |
I think this approach could work. |
Either approach works for me. |
@locii : the new overrides are not part of T3, therefore it will not be overridden when upgrade the plugin. However, put it in media folder is a good idea. We may allow developers add their own override name so we can have multiple overrides on the same site. |
The feature has been implemented in T3 1.2.0 now. New HTML base is put in media/t3/themes/[name] and declare in templateDetails.xml as:
|
I understand T3 has a set of HTML Overrides that override the Joomla Core output built into the T3 Plugin. I was wondering if we could allow for multiple HTML Overrides in the plugin that then would be selectable in the Plugin or via the Theme interface?
Scenario 1:
X Theme company wants to create their own HTML Override's specific to there needs. They might be wanting to move to the T3 Framework, and to ease the Template conversion process, move their existing overrides to T3. They wouldn't want these overrides to be in each template, but in the plugin so there is only 1 code base to update for all their templates.
Scenario 2:
X Developer just might not agree with the HTML coding approach of T3 and want to create there own. They wouldn't want to modify the T3 Core HTML Overrides because this would cause updating issues. They also would want their overrides to rest in the plugin, and not in the individual templates so there is only 1 code base/copy they need to worry about.
Scenario 3 (Soapbox Specific):
Similar to Scenario 1, we have tons of templates on J1.5 Custom HTML overrides. It would be nice to create a setup of our own overrides that mimic our J1.5 HTML as closely as possible so the conversion to T3 is easier. So sites that we are porting from our old platform, we can just easily change a parameter from using the T3 Overrides to using our J1.5 setup in the plugin. This would be great because we wouldn't have to re-write all our CSS for those sites making the switch.
The text was updated successfully, but these errors were encountered: