Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor end position for arrow function snippets #1

Closed
alexey-kozlenkov opened this issue Oct 5, 2018 · 1 comment
Closed

Cursor end position for arrow function snippets #1

alexey-kozlenkov opened this issue Oct 5, 2018 · 1 comment

Comments

@alexey-kozlenkov
Copy link

alexey-kozlenkov commented Oct 5, 2018

Hey @t7yang, seems like you've recently updated several function snippets to place cursor end position correctly.
Any reason why arrow function snippets have been missed?

"arrow function (ES2015)": {
  "prefix": "af",
  "body": "(${1}) => ${2}",
  "description": "arrow function (ES2015)"
},
"async arrow function (ES2015)": {
  "prefix": "afa",
  "body": "async (${1}) => ${2}",
  "description": "async arrow function (ES2015)"
},

I can quickly submit a PR for this if needed.

@t7yang
Copy link
Owner

t7yang commented Oct 5, 2018

thx @alexey-kozlenkov for remind me.
I do a review (c5aa31b) and make sure all snippets end with ${0}.

@t7yang t7yang closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants