Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad rendering of translated text in top app bar #34

Closed
lorenzovngl opened this issue Mar 5, 2023 · 3 comments
Closed

Bad rendering of translated text in top app bar #34

lorenzovngl opened this issue Mar 5, 2023 · 3 comments

Comments

@lorenzovngl
Copy link
Contributor

I'm working on Italian translation (#31) and I noticed that in the Batch Resize activity the English title fits perfectly, while the French and the Italian strings, which are longer, overflows.


Default language (English)

French

Italian

I came up with two possible solutions:

  • In the composable function, set a text size smaller than the default language for French and Italian, something like this:
if (app is using the default language){
    // Render text in the default size
} else if (app is using the French translation) {
    // Render the text optimally for French strings (maybe with a small text size)
} ...
  • Apply a marquee behavior to the text that overflows.

Also I got suggestions here and here.

@T8RIN
Copy link
Owner

T8RIN commented Mar 5, 2023

Maybe it will better to scale the font, until it perfectly fits in? Or use marquee, it is also possible solution, i think

@T8RIN
Copy link
Owner

T8RIN commented Mar 5, 2023

Fixed

@T8RIN T8RIN closed this as completed Mar 5, 2023
@lorenzovngl
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants