Feature: auto_context_queryset_filter #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added only to update mutation for now
mbuvarp
commented
Feb 21, 2021
Comment on lines
+192
to
+201
| extend_query = False | ||
| query_extension = Q() | ||
| auto_context_queryset_filter = cls._meta.auto_context_queryset_filter or {} | ||
| for field_name, context_name in auto_context_queryset_filter.items(): | ||
| if hasattr(info.context, context_name): | ||
| extend_query = True | ||
| query_extension &= Q(**{field_name: getattr(info.context, context_name)}) | ||
|
|
||
| if extend_query: | ||
| queryset = queryset.filter(query_extension) |
There was a problem hiding this comment.
@tOgg1 Should this thing perhaps be placed somewhere else?
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding this as a draft PR for now just to get your input, cause perhaps you would go about it differently (if you want this meta option at all). That's also why I've only added it to update for now (and patch by extension, I guess). The tests work though.
I'll also add docs if and before this PR goes though.