Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining a method in a header is now ugly (monospace) #1087

Closed
domenic opened this issue Sep 2, 2017 · 3 comments
Closed

Defining a method in a header is now ugly (monospace) #1087

domenic opened this issue Sep 2, 2017 · 3 comments
Labels

Comments

@domenic
Copy link
Collaborator

domenic commented Sep 2, 2017

Compare old: https://streams.spec.whatwg.org/commit-snapshots/26ba2c5de34c785778bc5ad3ca7d14eed7c6c4ef/#rs-prototype

with new: https://streams.spec.whatwg.org/#rs-prototype

I thought this might be because of our build post-processing step, but I removed that from console and it's still ugly.

At a minimum I think the section marker and the section number should stay in the normal font, even if the actual text of the header becomes monospace.

@tabatkins
Copy link
Collaborator

Ah, agreed, this is just the "wrap IDL stuff in <code>" getting a little trigger-happy. I'll specially detect headers and avoid doing that.

(I can't even just move it down to the actual header text, as it might not be all code. You can just use code directly if necessary, or autolinks in the text.)

@tabatkins
Copy link
Collaborator

Should be good now.

@domenic
Copy link
Collaborator Author

domenic commented Sep 14, 2017

Hmm, I re-ran the build for whatwg/console and am still getting the ugly headers. Maybe this didn't deploy to the CSSWG servers?

Would be good to add a regression test when doing this sort of thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants