Crash when preparing CSS Color 4 for CR (in addBikeshedVersion)

[svgeesus]

In preparation for publishing the CR I updated my clone of the bikeshed repo, installed, updated

git pull
pip install -e .
bikeshed update

Now I get a crash with bikeshed spec:

Chris@Nomad MINGW64 ~/Documents/GitHub/csswg-drafts/css-color-4 (main)
$ bikeshed spec
Traceback (most recent call last):
  File "c:\users\chris\documents\github\bikeshed\bikeshed\boilerplate.py", line 46, in addBikeshedVersion
    subprocess.check_output(
  File "C:\Python38\lib\subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "C:\Python38\lib\subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'git log -1 --format='Bikeshed version %h, updated %cd'' returned non-zero exit status 128.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Python38\Scripts\bikeshed-script.py", line 33, in <module>
    sys.exit(load_entry_point('bikeshed', 'console_scripts', 'bikeshed')())
  File "c:\users\chris\documents\github\bikeshed\bikeshed\cli.py", line 422, in main
    handleSpec(options, extras)
  File "c:\users\chris\documents\github\bikeshed\bikeshed\cli.py", line 477, in handleSpec
    doc.preprocess()
  File "c:\users\chris\documents\github\bikeshed\bikeshed\Spec.py", line 137, in preprocess
    self.processDocument()
  File "c:\users\chris\documents\github\bikeshed\bikeshed\Spec.py", line 213, in processDocument
    boilerplate.addBikeshedVersion(self)
  File "c:\users\chris\documents\github\bikeshed\bikeshed\boilerplate.py", line 57, in addBikeshedVersion
    bikeshedVersion = doc.dataFile.fetch("bikeshed-version.txt", type="readonly", str=True).strip()
TypeError: fetch() got an unexpected keyword argument 'type'

[svgeesus]

The previously installed bikeshed and the new one are both 3.7.0:

    Found existing installation: bikeshed 3.7.0
    Uninstalling bikeshed-3.7.0:
      Successfully uninstalled bikeshed-3.7.0
  Running setup.py develop for bikeshed
Successfully installed bikeshed-3.7.0 certifi-2022.6.15 result-0.8.0 typing-extensions-4.2.0 uri-template-1.2.0 urllib3-1.26.9 widlparser-1.1.0
WARNING: You are using pip version 22.0.4; however, version 22.1.2 is available.
You should consider upgrading via the 'C:\Python38\python.exe -m pip install --upgrade pip' command.

[svgeesus]

I was able to install the release version pip uninstall bikeshed then pip install bikeshed although being less recent than GitHub, it lacked the recent fix to the implementation banner for example.

[tabatkins]

Oh funky, that particular codepath isn't exercised by any of my test code, so I missed that I'd gotten the keyword argument wrong. Fixed things up, should be good now.