Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off more inline styles for WHATWG #1767

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Conversation

annevk
Copy link
Collaborator

@annevk annevk commented Sep 23, 2020

And also switch to a non-legacy syntax and align defaults between normal and RD.

@annevk annevk requested a review from domenic September 23, 2020 09:21
@annevk
Copy link
Collaborator Author

annevk commented Sep 23, 2020

(I guess when landing this it can close whatwg/meta#188.)

@annevk
Copy link
Collaborator Author

annevk commented Sep 23, 2020

@sideshowbarker was it intentional that -RD did not have style-mdn-anno off, script-mdn-anno off?

@annevk
Copy link
Collaborator Author

annevk commented Sep 23, 2020

I guess since Use Dfn Panels is off that doesn't matter. (I'll include omitting them there to keep things as much the same as possible though.) There are some other bits that seem out-of-sync though.

@domenic
Copy link
Collaborator

domenic commented Sep 23, 2020

Looking at https://dom.spec.whatwg.org/review-drafts/2019-06/ it seems that the mdn anno styles are done inline, so we probably shouldn't turn them off for review drafts yet.

To fix that we'd need to move https://github.com/whatwg/whatwg.org/blob/7a2314f5c2ed2a29668b24d5f6bc7d94bd2f056a/resources.whatwg.org/standard-shared-with-dev.css#L96 into https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/spec.css. Which we should probably do anyway; e.g. https://html.spec.whatwg.org/review-drafts/2020-01/#events is pretty broken.

@annevk
Copy link
Collaborator Author

annevk commented Sep 23, 2020

So https://dom.spec.whatwg.org/review-drafts/2020-06/ is newer and doesn't include any MDN boxes. The shared-with-W3C version has a custom pipeline that's not under version control (yet) so I'm not sure that's a good reference.

@tabatkins
Copy link
Collaborator

This looks good overall; feel free to merge whenever y'all want.

@sideshowbarker
Copy link
Contributor

@sideshowbarker was it intentional that -RD did not have style-mdn-anno off, script-mdn-anno off?

Not intentional

@annevk annevk merged commit 6c3b0bd into master Sep 24, 2020
@annevk annevk deleted the annevk/whatwg-boilerplate branch September 24, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants