Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary type attribute from <style> and <script> #2227

Closed
wants to merge 1 commit into from

Conversation

zcorpan
Copy link
Contributor

@zcorpan zcorpan commented Feb 10, 2022

The attributes are obsolete and are generating warnings in validator.w3.org/nu as per https://html.spec.whatwg.org/multipage/obsolete.html#warnings-for-obsolete-but-conforming-features

This is similar to speced/bikeshed-boilerplate#16

@tabatkins
Copy link
Collaborator

You need to regen the tests alongside this; run bikeshed test --rebase.

@tabatkins
Copy link
Collaborator

Tho, since the built-in boilerplates are dramatically out of date at this point anyway, just fixing this issue will be putting a bandaid on a bullet wound. So nm, I'll just go ahead and close; I've been wanting to do a readonly update for a while, it just requires a lot of boring verification that everything's still as expected.

@tabatkins tabatkins closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants