Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate JPG according to EXIF #549

Open
ccfs opened this issue Jan 27, 2022 · 13 comments
Open

Rotate JPG according to EXIF #549

ccfs opened this issue Jan 27, 2022 · 13 comments

Comments

@ccfs
Copy link

ccfs commented Jan 27, 2022

I notice that TE has been enhanced to do so, but this is successful only with 4 add-ons. At least 6 other add-ons fail. Please help to solve this problem. Thanks.

  • Succeeds:
    Tooltip preview
    Preview in background
    Thumbnail plus
    Show thumbnails with small icons

  • Fails:
    Preview
    Preview window
    Menu image
    Menu image plus
    Retouch
    Background image

20220127_101549

@ccfs
Copy link
Author

ccfs commented Jan 28, 2022

The latest version can now do the rotation. However, there are 3 small problems:

Background image
On OPTIONS page, JPG image is not rotated according to EXIF (the add-on works on file list background).
Background image

Tooltip preview
The pop-up seems to be NOT FITTING if JPG image has been rotated according to EXIF.
Tooltip preview

Preview / Preview window
Big image shows up much SLOWER than when it is shown by other add-ons.
Preview
Preview in background

@ccfs
Copy link
Author

ccfs commented Jan 29, 2022

With the latest version, the problem of "Tooltip preview" is solved. The problems of "Background image", "Preview" and "Preview window" still happen.

Regards,

@ccfs
Copy link
Author

ccfs commented Jan 30, 2022

The problems are solved. "Preview" and "Preview window" now needs 2 seconds for the above file. Not as fast as other add-ons but are acceptable.

@ccfs ccfs closed this as completed Jan 30, 2022
@ccfs
Copy link
Author

ccfs commented Jan 31, 2022

Please help to solve 3 issues. Thanks.

(1) Speed up "Preview window" and "Background image"
I notice that "Preview" 1.39 successfully speeds up in JPG rotation. Please make the same enhancement to "Preview window" and "Background image" (options page).

(2) "Preview" over-shrinks
If a pane height has been specified, a big image may over-shrink and does not fit the pane.
250
139-250

(3) Shortcut and symbolic link - not rotated
JPG rotation is missing if the file is a shortcut (.LNK) or a symbolic link.
shortcut

@ccfs ccfs reopened this Jan 31, 2022
@ccfs
Copy link
Author

ccfs commented Feb 1, 2022

I have tried TE 22.1.31 regarding SHORTCUT file. Thumbnails and previews of image shortcut files are OK, except "Preview" [problem (3) above] and "Preview window" add-ons.

(S1) JPG rotation takes too long for a big image
1a
1b

(S2) The image flashes once after it shows
(S3) GIF animation does not work
2a
2b

@ccfs
Copy link
Author

ccfs commented Feb 3, 2022

I have tested the latest version of TE and add-ons for certain cases. Problem (1), (2), (3), (S1) and (S3) are solved.

3 problems are found:

(P1) Preview - Cannot playback MP4
The play button no longer works for MP4 (but WAV and MP3 are OK).
20220203_134512
20220203_134545

(P2) Preview window - Rotated JPG flashes once
Problem (S2) is now narrowed down to rotated JPG only.
If a JPG that requires ROTATION is chosen by moving BOTH selection rectangle and focus rectangle to it while TE is the ACTIVE window, the image in the Preview window flashes once after it shows up.
1
2
It means that the problem does NOT happen if either:
. No rotation is required
. Focus rectangle is moved but not selection rectangle (by pressing Ctrl + arrow key)
. Preview window is the active window (and use an arrow key to go to a file)

(P3) Tooltip preview - JPG drawing fails
My failed files are with "Standard" orientation (no rotation)
20220203_144626

@ccfs
Copy link
Author

ccfs commented Feb 4, 2022

The latest version as at 2022/2/4 just solves problem (P1). However there are some new problems:

(P4) Preview - After playing MP3 file, a TypeError occurs when another item is selected.
Finish playback of MP3 file
1
Select another item
2
A TypeError occurs
3

(P5) Preview - "Cannot play" indicator is changed to something not understandable.
Playback MPG file
1 41a
Windows Media Player has been disabled on my system. The pane should have shown a "cannot play" indicator.
1 41b
The previous version did this correctly.
1 40

(P6) Preview - Snapshot of MP4 file produced by "Thumbnail engine" add-on should better be hidden when the film is played.
1 41
1 36

(P7) Preview window - Incorrectly shows the info of a previous item (or does not show any)
1a
1b
Move to another item
2a
2b

(P2) Preview window - Flashes once
The flash problem of rotated JPG is solved. However it still happens in "Preview window" when a snapshot of MP4 file (and MP3 cover page) produced by "Thumbnail engine" add-on shows.
MP4-1
MP4-2

@ccfs
Copy link
Author

ccfs commented Feb 5, 2022

The latest version as at 2022/2/5 solves problem (P4), (P5) and (P6). However there are still some problems:

(P7) Preview window - Last image and info incorrectly shows for a text file
Problem (P7) has been narrowed down to text file.

Select an image file
1a
1b
Switch to a text file
2a
2b

(P8) Preview window - Change window title for text file
(P9) Preview window - Disable editing for text file
20220205_154153
20220205_154820

(P10) Preview window - The tip of an image file may incorrectly be from the last selection.
Select an image file
20220205_160408
20220205_160413
Select another
20220205_160420
20220205_160435

(P11) Preview window - The window should become blank when nothing is selected
Select an item
20220205_160921
20220205_160929
Deselect all
20220205_160939
20220205_160952
If the image is a MP3 cover page or a MP4 snapshot (produced by "Thumbnail engine"), and the image is clicked, a script error occurs.
20220205_161033

(P12) Allow translation of "Play" to local language
Preview
P
Preview window
PW

@ccfs
Copy link
Author

ccfs commented Feb 7, 2022

The latest version as at 2022/2/7 solves problem (P8) to (P12). However there are still some problems:

Problem (P2), (P3) and (P7) still occurs.
(P7) Info is correct now but the last image still incorrectly shows up for a text file.

(P13) Preview window - MP3 playback panel does not show up
If the preview window is opened BEFORE a MP3 file is selected, when the file is played, MP3 playback panel does not show up.

Open the preview window
20220207_154837
20220207_154856
Select a MP3 file
20220207_154902
20220207_154907
Click the play button. The file is played, but the playback panel does not show up.
20220207_154914

(P14) Preview window - TXT file content does not show up
If the preview window is opened BEFORE a TXT file is selected, the file content does not show up.

Open the preview window
20220207_155034
20220207_155052
Select a text file. The file content does not show up.
20220207_155101
20220207_155107

(P15) Preview - Title bar disappears after restoring from full screen

  1. Press F11 key to change to full screen
    20220207_160719
  2. Play a MP4 file in preview pane.
    20220207_160956
  3. Click the "Full screen" button of playback panel. It is now in full screen.
    20220207_161049
  4. Restore TE window by pressing F11 key or clicking the "Full screen" button. Title bar disappears.
    20220207_161131

(P16) Preview - File info unexpectedly remains after deselecting all
If the current selection is a media file,
20220207_160329
after deselecing, file info unexpectedly remains.
20220207_160337

@ccfs
Copy link
Author

ccfs commented Feb 8, 2022

My test results of the latest version as at 2022/2/8:

  • Problem P2, P7, P13, P14 and P15 are solved.
  • Problem P3 still happens.
  • Problem P6 re-happens.

(P17) Tooltip preview - Malfunction after the tip of a shorten column shows
View an image
1
Move the mouse pointer to a shorten column (Date Modified). The tip pop-up showed the full text. However a thumbnail of the image also unexpectedly showed.
2
Move the mouse pointer to the name column. The add-on malfunctioned.
3

(P18) Tooltip preview - A tall image may go beyond screen top if KEYBOARD is used for selection
1
Press UP key. The tip pop-up goes beyond screen top, although there is enough space below the selected item.
2

@ccfs
Copy link
Author

ccfs commented Feb 9, 2022

My test results of the latest version as at 2022/2/9:

  • Problem P6 and P17 are solved.
  • Problem P3 still happens. Please use this JPG file to reproduce and solve the problem.
  • Problem P18 still happens.

(P19) Tooltip preview - Preview does not show if a user TYPES to jump to an item.
20220209_120836
Type "p". "Printer.png" is selected but no tip pop-up shows.
20220209_120843

(P20) Tooltip preview - Should also work on a shortcut (LNK) to a text file
20220209_123230

@ccfs
Copy link
Author

ccfs commented Feb 10, 2022

Problem (P3) and (P20) are solved with the latest version as at 2022/2/10.

@ccfs
Copy link
Author

ccfs commented Feb 11, 2022

(P18) is also solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant