Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow external OAuth config files without having to embed one #1108

Open
xsgao-github opened this issue Apr 5, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@xsgao-github
Copy link

xsgao-github commented Apr 5, 2023

Is your feature request related to a problem? Please describe.

Quote from https://tableau.github.io/connector-plugin-sdk/docs/oauth:

However in both cases, at least one embedded config is still required.

For Starburst Enterprise and Galaxy, users define which IDP to use for OAuth. So we can't embed a generic OAuth config in our connector, and have to put a dummy one labeled as ..._template. This is not user-friendly.

image

Describe the solution you'd like
Remove the restriction at least one embedded config is still required so we can build a generic connector without embed OAuth config.

Describe alternatives you've considered
None.

About You
Name: Song Gao
Company: Starburst Data

@lukewrites lukewrites added the enhancement New feature or request label Apr 5, 2023
@carlossc
Copy link

At Denodo, we are also interested on this.

About You:
Name: Carlos Santos Canelles
Company: Denodo Technologies

@carlossc
Copy link

@xsgao-github , we are going to include a default OAuth configuration for Azure AD so at least there is something there that can be useful.

@rosswbrown
Copy link
Contributor

Thanks for your feedback. We are tracking this in our backlog as a potential improvement for a future release. This issue will be left open and notified if there are any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants