-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguous Error Message for TDVT Failures #1190
Comments
Can you attach your |
I'd recommend looking at the
You can also attach your full artifacts here, or link to your repo. Please also include the version of TDVT you are running to see if the repeated error message is a known issue or not. |
TDVT Version: 2.7.5 |
Works for me after modifying the class tag and renaming the dialect file (to the dialect.tdd). |
@yurifal Were you able to repro before the file name changes? I'm still getting an error in the tests. |
@rosswbrown We did find the following in the tab_query logs for the two tests:
Not sure if this helps. |
My bad, I've replied with the total nonsense. |
Just to follow up on the other comment, based on the logs you've provided I don't believe there is any need to rename the connector. My guess is this is your in development connector loading as expected:
Looking at your
There are additional logs in the |
It is possible the lack of time field handling into a DateTime type might be impacting the ability to run some tests like
The
This is an example of the query generated by that test:
|
Tried excluding that test and got the same ambiguous error messages unfortunately. |
I think the best starting point may be to get the calcs_data.time to pass and match the expected file. This column is the basis for at least a few of the failing tests. A connector's Date Literal Support is described in that link and some additional details within this previous answer. Since the connector attached above is using
If you're still seeing a large number of failures try using more general skips and reducing the number of test suites used as a starting point. For example:
You can also remove suites entirely like |
I'll give that a shot. Thanks @rosswbrown I also noticed that all of the failures with the error messages are related to the Staples tests. Does that change our strategy for debugging at all? |
As you identified originally I think this a situation where one of the logical Staples tests is causing a cascading failure, similar to what is reported in #1123. My best guess is still to start with the suggestions above. Previously we'd established if you can skip the failing test then the others will succeed. You are also able to run tests individually in this style, which may help:
|
I've tried the suggestion of excluding tests failing with the following error message:
I noticed if I skipped the tests with that error, a new test in the same suite would then fail with that error. I repeated the cycle until no tests were left in the logical staples test. Based on that assumption, there doesn't seem to be one single culprit, but the entire logical staples test suite. I also excluded the calcs_data.time and operator.datetime.minus_time tests, but they didn't affect the tests mentioned above. Here is the full list of the tests that I'm excluding:
|
One thing I've determined is that certain exceptions during query formation, like the one you're seeing above, will cause the rest of the tests in the suite to be skipped. Currently this is by design, though we're exploring changing that in a future release to make this easier to develop with. I see the connector attached is an update to an existing one, which I believe passed these same tests previously. I'm not sure what else to suggest in isolation. Perhaps you can verify the previous version and/or driver to help eliminate some variables. In general four independent factors could cause a test to fail:
|
Let us know if you need this issue reopened or feel free to open another as well. Thanks. |
Thanks for your help Ross. It seems that the test data was being loaded incorrectly into our data source. I've loaded it into a postgres source within Dremio and noticed all those errors went away. |
About You:
Name: Ravjot Brar
Company: Dremio
I have two tests failing (
lod.10_As in-out Set
andBUGS.B14080
) that have the following error message:There's no SQL generated and I couldn't find anything useful in the logs. Based on my research I'm assuming this query tries to use a function that isn't defined in the dialect file. How do I find out which function exactly?
The rest of the ~60 failures have the following error message, which tells me they're a consequence of the two test failures above:
Happy to provide any other info if needed.
The text was updated successfully, but these errors were encountered: