fix: loosen react dependency versions #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are probably other changes that need to be taken to support react 18 fully, but most of it should work with current setup. Other changes will be done in next branch but this at least allows us to try out react 18 without the CI failing.
wahidfarid
approved these changes
Oct 3, 2022
whanchong
approved these changes
Oct 3, 2022
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
|
🚀 PR was released in |
1 similar comment
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are probably other changes that need to be taken to support react 18 fully, but most of it should work with current setup. Other changes will be done in next branch but this at least allows us to try out react 18 without the CI failing.
Specifically related to the TableKit next branch which has some installation issues due to this - canary version was tested here: tablecheck/tablekit#131
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/eslint-config@1.8.2-canary.78.3156990612.0 npm install @tablecheck/scripts@2.3.8-canary.78.3156990612.0 # or yarn add @tablecheck/eslint-config@1.8.2-canary.78.3156990612.0 yarn add @tablecheck/scripts@2.3.8-canary.78.3156990612.0