Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint needs extra configs to resolve paths correctly #86

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Oct 2, 2023

Merged the release CI fixes from another branch here as I didn't figure out that one just needed the npm run build:ci changes to run properly 🤦

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/frontend-audit@2.0.0-canary.86.6377429546.0
npm install @tablecheck/commitlint-config@2.0.0-canary.86.6377429546.0
npm install @tablecheck/eslint-config@2.0.0-canary.86.6377429546.0
npm install @tablecheck/eslint-plugin@2.0.0-canary.86.6377429546.0
npm install @tablecheck/nx@2.0.0-canary.86.6377429546.0
npm install @tablecheck/prettier-config@2.0.0-canary.86.6377429546.0
npm install @tablecheck/semantic-release-config@3.0.0-canary.86.6377429546.0
npm install @tablecheck/frontend-utils@3.0.0-canary.86.6377429546.0
# or 
yarn add @tablecheck/frontend-audit@2.0.0-canary.86.6377429546.0
yarn add @tablecheck/commitlint-config@2.0.0-canary.86.6377429546.0
yarn add @tablecheck/eslint-config@2.0.0-canary.86.6377429546.0
yarn add @tablecheck/eslint-plugin@2.0.0-canary.86.6377429546.0
yarn add @tablecheck/nx@2.0.0-canary.86.6377429546.0
yarn add @tablecheck/prettier-config@2.0.0-canary.86.6377429546.0
yarn add @tablecheck/semantic-release-config@3.0.0-canary.86.6377429546.0
yarn add @tablecheck/frontend-utils@3.0.0-canary.86.6377429546.0

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Unit Test Results

  1 files    3 suites   15s ⏱️
59 tests 59 ✔️ 0 💤 0
63 runs  63 ✔️ 0 💤 0

Results for commit 26975cf.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC added the major Increment the major version when merged label Oct 2, 2023
@SimeonC SimeonC force-pushed the fix-eslint-setup-and-release branch 3 times, most recently from 400fbb3 to f01639f Compare October 2, 2023 06:44
@SimeonC SimeonC enabled auto-merge (rebase) October 2, 2023 06:46
@SimeonC SimeonC force-pushed the fix-eslint-setup-and-release branch from f01639f to 58b4ff7 Compare October 2, 2023 07:50
Merged the release CI fixes from another branch here as that one is failing for unknow reasons

Fix over-agressive shortest imports
@SimeonC SimeonC force-pushed the fix-eslint-setup-and-release branch from 58b4ff7 to 26975cf Compare October 2, 2023 07:54
@SimeonC SimeonC merged commit 253bb03 into main Oct 2, 2023
5 checks passed
@SimeonC SimeonC deleted the fix-eslint-setup-and-release branch October 2, 2023 08:02
@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Oct 11, 2023
@tablecheck-public-automation
Copy link
Collaborator

🚀 PR was released in @tablecheck/frontend-audit@6.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants