Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to cancel the thumb up / thumb down review #184

Open
olizilla opened this issue Jun 22, 2015 · 6 comments
Open

No way to cancel the thumb up / thumb down review #184

olizilla opened this issue Jun 22, 2015 · 6 comments
Assignees
Labels

Comments

@olizilla
Copy link
Member

I accidentally pressed the wrong thumb icon, but then couldn't undo it without reloading the page which'd be tedious if I'd already filled out a review comment. Suggest that we keep the other thumb icon visible and shown as unselected when they click on a positive / negative review icon.
screenshot 2015-06-22 15 46 35

@richsilv
Copy link
Contributor

Agreed, this is what we've got now if you click thumbs up first (for example:

sandstorm app store

@jadeqwang @neynah are you happy with this?

@neynah
Copy link
Contributor

neynah commented Jun 29, 2015

@richsilv I think when you click thumbs up, it should still display the thumbs up rather than displaying the thumbs down. I know the thumbs down button displays so that the user can change their mind on the review. But I think it would be more intuitive perhaps as a toggle button or a drop-down button. The thumbsup/down that's displayed should be reflective of the current review (positive or negative). I also think that it should stay static, perhaps on the left side of "write-a-review" just so it doesn't jump around.

Also it's probably best to not pre-select an option for the rating (e.g. it gets the job done, it's amazing, it's broken, etc.) as it takes a little more effort to switch away from a selection and this might actually have an unintended impact on reviews on a larger scale. Thoughts @jadeqwang?

@jadeqwang
Copy link

Agree with @neynah on all points.

@richsilv
Copy link
Contributor

richsilv commented Jul 2, 2015

@neynah - could you send me a couple of screenshots of how the interaction should work? I agree that having the thumbsup/down displayed be reflective of the current review makes sense, but it also means that you can't change your mind and select the other one.

Should we have all four buttons (the specific "It's amazing/broken" options) and then the two thumbs up, with the relevant one semi-highlighted when the user has selected it?

@neynah
Copy link
Contributor

neynah commented Jul 2, 2015

@richsilv If we have a toggle then it should let you easily swap between the two. I'll mock it up today within the next few hours to illustrate that better. My bad!

@neynah
Copy link
Contributor

neynah commented Jul 2, 2015

I think I describe it in #189. Sounds like the same issue so I'll just add the mock-up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants