-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bootstrap imports #1477
Fix bootstrap imports #1477
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
there is a bug with import stylesheet:
|
i used includePaths solution since it should resolve all reported issues |
@SyntaxJoker thank you! This looks good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I am using node-sass with webpack and these changes work without any required change on my end 👍
But I have one remark: we should use the same syntax everywhere.
There are at least three places where still @import "~
is used.
Could you adapt them as well @SyntaxJoker ?
good point, i will change those imports aswell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SyntaxJoker 🚀
I confirm, thanks! |
@codecalm @SyntaxJoker tabler/tabler-icons should have the same fix? |
This is another issue, its caused by exports field |
Related PR:
bootstrap
import fix #1384Related issues:
#1475
#1456
#1394