Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionInfo is null on Manjaro #52

Closed
zacanger opened this issue Aug 7, 2018 · 1 comment · Fixed by #55
Closed

versionInfo is null on Manjaro #52

zacanger opened this issue Aug 7, 2018 · 1 comment · Fixed by #55

Comments

@zacanger
Copy link
Contributor

zacanger commented Aug 7, 2018

Cloned from master to debug.

NAME="Manjaro Linux"
ID=manjaro
PRETTY_NAME="Manjaro Linux"
ANSI_COLOR="1;32"
HOME_URL="https://www.manjaro.org/"
SUPPORT_URL="https://www.manjaro.org/"
BUG_REPORT_URL="https://bugs.manjaro.org/"
[:~/Downloads/envinfo] master(+1/-0)* ±

[:~/Downloads/envinfo] master(+1/-0)* ± node src/cli.js
(node:10691) UnhandledPromiseRejectionWarning: TypeError: Cannot read property '1' of null
    at utils.run.then.v (/home/z/Downloads/envinfo/src/helpers.js:297:43)
(node:10691) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:10691) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not
handled will terminate the Node.js process with a non-zero exit code.
[:~/Downloads/envinfo] master(+1/-0)* ±

Replacing line 295 of helpers with const versionInfo = (v || '').match(/VERSION="(.+)"/) || []; fixes the issue:

[:~/Downloads/envinfo] master(+1/-1)* ± node src/cli.js

  System:
    OS: Linux 4.14 Manjaro Linux undefined
    CPU: x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
    Memory: 26.39 GB / 31.30 GB
    Container: Yes
    Shell: 4.4.23 - /bin/bash
  Binaries:
    Node: 10.7.0 - /usr/local/bin/node
    npm: 6.2.0 - /usr/local/bin/npm
  Utilities:
    CMake: 3.11.4 - /usr/bin/cmake
    Make: 4.2.1 - /usr/bin/make
    GCC: 8.1.1 - /usr/bin/gcc
    Git: 2.18.0 - /usr/bin/git
  Virtualization:
    Docker: 18.05.0 - /usr/bin/docker
  IDEs:
    Nano: 2.9.8 - /usr/bin/nano
    Vim: 8.1 - /usr/bin/vim
  Languages:
    Bash: 4.4.23 - /usr/bin/bash
    Go: 1.10.3 - /usr/bin/go
    Perl: 5.26.2 - /usr/bin/perl
    PHP: 7.2.7 - /usr/bin/php
    Python: 3.6.6 - /usr/bin/python
    Ruby: 2.5.1 - /usr/bin/ruby
  Databases:
    SQLite: 3.24.0 - /usr/bin/sqlite3

[:~/Downloads/envinfo] master(+1/-1)* ±

I'd be happy to open a PR.

@zacanger
Copy link
Contributor Author

zacanger commented Aug 7, 2018

Whoops, this is a duplicate of #51, sorry. I'm going to close in favor of that issue.

@zacanger zacanger closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant