Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending JSON message encoded in a file with "abaco submit" #20

Open
mwvaughn opened this issue Aug 7, 2019 · 2 comments
Open
Assignees
Labels
enhancement New feature or request test please Need help validating a feature or fix
Milestone

Comments

@mwvaughn
Copy link

mwvaughn commented Aug 7, 2019

A popular feature of the agave-cli is the ability to submit most complex data structures from files on disk. This is not really needed for most Abaco operations. However, abaco run is an exception.

When a user wishes to send a structured JSON document as the message payload, they must encode and quote it themselves, a shaky proposition in the UNIX command line. Add in any need to script job submission in subshell and it's nearly impossible. It is also challenging to share example messages with other users.

To address this:

  1. Extend abaco run to accept -F <filename>
  2. Read the file from disk, compressing and validating it as JSON using jq
  3. Send to the target actor's mailbox with a Content-Type: application/json header
@mwvaughn mwvaughn added enhancement New feature or request test please Need help validating a feature or fix labels Aug 7, 2019
@mwvaughn mwvaughn added this to the v1.3.0 milestone Aug 7, 2019
@mwvaughn mwvaughn self-assigned this Aug 7, 2019
@mwvaughn
Copy link
Author

mwvaughn commented Aug 7, 2019

Implemented in:

@mwvaughn mwvaughn closed this as completed Aug 7, 2019
@mwvaughn
Copy link
Author

Reopening to test

@mwvaughn mwvaughn reopened this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test please Need help validating a feature or fix
Projects
None yet
Development

No branches or pull requests

1 participant