Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline styling to allow default browser selection elements #677

Open
musm opened this issue Aug 7, 2020 · 5 comments
Open

Remove outline styling to allow default browser selection elements #677

musm opened this issue Aug 7, 2020 · 5 comments

Comments

@musm
Copy link

musm commented Aug 7, 2020

The outline focus border shows up after you click the element:

E.g.: click a link then this shows up before the page changes
image

This border should only show up after hitting Tab

@NitinNair89
Copy link

Hiding outline effects is not recommended as far as accessibility is concerned. The browser will add default styles for element outline when element is in focus / tabbed / clicked.

@musm
Copy link
Author

musm commented Oct 2, 2020

Right and I agree, my suggestion here is not to add any styling to outline effects by default and to allow browsers to apply their default styling, which are more accessibility focused. The default Tachyons outlines are not great from both a design and accessibility perspective.

@NitinNair89
Copy link

Gotcha @musm . The title was misleading, a bit. 🙂

@musm musm changed the title outline border shows up after you click element Remove outline styling to allow default browser selection elements. Oct 2, 2020
@musm musm changed the title Remove outline styling to allow default browser selection elements. Remove outline styling to allow default browser selection elements Oct 2, 2020
@orionrush
Copy link

I agree, this should probably be the default behaviour, and is in keeping with Tachyons' ethos. Can we find any other sources to evidence this being best practice in terms of a11y?

@ankitakul
Copy link

Hello, is this issue still open? I have a project for a software methodology class to contribute to an open source repo and I am very interested in working on this project. Could I be assigned to this issue? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants