Favor docker compose v2 in ansible tasks #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
1834_favor_community.docker.docker_compose_v2
branch
3 times, most recently
from
20c8409
to
23a9ef7
Compare
roschaefer
reviewed
May 26, 2024
| build: never | ||
| pull: always | ||
| state: present | ||
| wait: true |
There was a problem hiding this comment.
@mattwr18 this is a nice new feature that will ensure that all containers are healthy before proceeding. In our pair-programming today we were facing the issue of silent failures.
roschaefer
reviewed
May 26, 2024
| - name: docker-compose | ||
| - name: passlib | ||
| pip_install_packages: | ||
| - name: passlib |
There was a problem hiding this comment.
passlib is required for htpasswd role. The other two seem not required.
roschaefer
reviewed
May 26, 2024
| - role: geerlingguy.docker | ||
| docker_packages_state: latest |
There was a problem hiding this comment.
I'm willing to keep this variable. Opinions/thoughts?
roschaefer
force-pushed
the
1834_favor_community.docker.docker_compose_v2
branch
from
23a9ef7
to
fb0cdd1
Compare
roschaefer
force-pushed
the
1834_favor_community.docker.docker_compose_v2
branch
from
3324708
to
5802351
Compare
|
Also checked your changes @roschaefer and they look good... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1834
I've tested running the
ansible/restore_locallyandansible/siteplaybooks and nothing appears to be broken.