🚧 Swift 3 #55
Closed
🚧 Swift 3 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? Is it still a WIP? @phatblat @tadeuzagallo |
|
Yeah, I converted it to Swift 3 (which is now obsolete), but never got the embedded chrome plugin to work inside the macOS app. More recently, I updated the project to Swift 5, but I don't know what's going on inside the webview and haven't spent much time to debug it. Anyway, since my initial PR #54 has been ignored for 2 years now, I figure this project is dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP: Not ready to merge 🚧
Started building the project to see if I can resolve #54, but the codebase is really out-of-date. So, figured I'd first convert the code to Swift 3. Then, if that goes well, migrate to Swift 4. However, I don't see any recent activity on this project. If I can finish this up can someone even push out a release? Or, should I just build it for myself?