Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streak for users I'm following doesn't work past a year #41

Closed
ljharb opened this issue Feb 18, 2015 · 14 comments
Closed

Streak for users I'm following doesn't work past a year #41

ljharb opened this issue Feb 18, 2015 · 14 comments

Comments

@ljharb
Copy link

ljharb commented Feb 18, 2015

https://github.com/getify/ has 423 but shows up as 366, and https://github.com/jdalton has 573 but shows up as 365.

@ljharb
Copy link
Author

ljharb commented Feb 18, 2015

Also, how do I refresh my followers list in the client? I followed somebody new and right clicked the menu but it's not showing them.

@tadeuzagallo
Copy link
Owner

Well, about the number of commits, it happens on your profile as well, if you have more than 365 commits, the problem is that github just shows the chart for the ongoing year, and I have no idea how we can get the older commits... If you have any insight let me know.

As about the refresh, there's no way right now, there are a few issues with the following page, most of then caused because I wanted to sort the people by the streak length, but I just thought about removing it and replacing by a search field...

@ljharb
Copy link
Author

ljharb commented Feb 18, 2015

Are you scraping the chart, or is there an API? If scraping, the "current streak" (span.contrib-number) is the accurate number.

(I think both sorting and searching the user list would be good)

@tadeuzagallo
Copy link
Owner

I hadn't actually thought about that... haha
I'm scrapping just the chart (https://github.com/:username/contributions), but that could be a better ideia.
About the sort, the problem is that some people are following like 900 people, which means ~9 requests to get the list of users + 900 requests to get the streak per user.

@ljharb
Copy link
Author

ljharb commented Feb 23, 2015

That seems problematic only for the initial pull - once you've got the list, then you know who the most important/likely people are to scrape frequently, which are the ones at the top of the list of non-zeroes sorted by streak length. The zeroes could be scraped much more rarely.

For the initial load, you could certainly stagger those 900 requests over a longer length of time, and provide a text box (for me to enter usernames I want scraped immediately) or a refresh button on a list of usernames (for me to trigger an immediate scrape) - it's a tiny bit clunkier, and you'd need a "loading streak" indicator which would stick around for awhile (but you'd want that regardless), but it would let me prioritize the few people I want to compete with :-)

@ljharb
Copy link
Author

ljharb commented Apr 8, 2015

Any update on this?

@tadeuzagallo
Copy link
Owner

No, nothing yet 😞
I've been super busy, sorry, but I'll try to find some time to work on it... but if you wan't to take that on the mean time... you're more than welcome :)

@ljharb
Copy link
Author

ljharb commented Sep 27, 2015

ping :-)

@tadeuzagallo
Copy link
Owner

Hey, a little bit late but... I tried to fix it on v0.3.9, let me know if you see any issues.

@ljharb
Copy link
Author

ljharb commented Oct 26, 2015

I don't seem to be able to update past v0.3.8. I click the "restart and apply" button and it just keeps telling me I'm on that version. I was able to update from v0.3.7 to v0.3.8 tho.

@tadeuzagallo
Copy link
Owner

That's bad... I didn't change anything related to that though, maybe
something changed in El Capitan, I'll take a look.
On Mon, 26 Oct 2015 at 05:06, Jordan Harband notifications@github.com
wrote:

I don't seem to be able to update past v0.3.8. I click the "restart and
apply" button and it just keeps telling me I'm on that version. I was able
to update from v0.3.7 to v0.3.8 tho.


Reply to this email directly or view it on GitHub
#41 (comment)
.

@ljharb
Copy link
Author

ljharb commented Oct 26, 2015

I'm still on Yosemite.

@tadeuzagallo
Copy link
Owner

The good news are that I think I've fixed it, the bad news are that I screwed up before :(
I think I've generate the app before bumping the version, so you might have already updated, plus the download code was broken, which means that everyone might get stuck in that state ( :( again).

Let me know how it goes for you.

@ljharb
Copy link
Author

ljharb commented Oct 27, 2015

I was able to successfully update to v0.3.10 - this appears to fix my issue, thanks!

update: i actually had to delete and reinstall the one that was stuck on v0.3.8 :-(

@ljharb ljharb closed this as completed Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants