Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kellyroach/tapgesture #4

Closed
wants to merge 5 commits into from

Conversation

kellyroach
Copy link

@kellyroach kellyroach commented Aug 29, 2018

This pull request

  • Adds a tap gesture recognizer to the demo app so that
    whenever the user taps the screen, the user is welcomed with a new
    random conical gradient. This is the same behavior which was and still is
    available by rotating device twice, e.g. portrait -> landscape -> portrait .
  • Adds an AppIcon and LaunchImage to the demo app.
  • Fixes repo issue startAngle/endAngle Behavior
    startAngle/endAngle Behavior #3

@tadija
Copy link
Owner

tadija commented Sep 28, 2018

Hi @kellyroach, thank you for your efforts, but I've decided not to merge this.

The thing is that I like better how gradient looks before your changes:

screen shot 2018-09-27 at 22 51 46

then after:

screen shot 2018-09-27 at 23 06 39

Also #3 may be fixed with just configuring locations properly:

screen shot 2018-09-27 at 23 16 26

which also looks differently after your fix:

screen shot 2018-09-27 at 23 15 11

P.S. Thanks for the tap gesture hint, I've added that to the example project!

@tadija tadija closed this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants