Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic Framework support & Carthage support #21

Closed
wants to merge 5 commits into from

Conversation

Jeehut
Copy link

@Jeehut Jeehut commented Jan 12, 2016

This pull request adds iOS, tvOS and OSX targets with shared schemes (for installation via Carthage) and configures those to work as a dynamic framework. Also a section to the README about Carthage installation was added.

This should solve #8.

@Jeehut
Copy link
Author

Jeehut commented Jan 12, 2016

For the time being you can put github "Dschee/AERecord" "feature/framework-support" into your Cartfile and run carthage update until this is merged and a new version is released (with a tag named '2.0.1' or 'v2.0.1').

@Jeehut Jeehut changed the title Add Dynamic Framework support + Carthage support Add Dynamic Framework support & Carthage support Jan 12, 2016
@Jeehut
Copy link
Author

Jeehut commented Jan 17, 2016

I just tried using my branch included as a framework, but at least when running tests there were issues with both finding the correct bundle(Identifier) (this one I tried to fix in the last commit) and creating an entityDescription object (probably cause entityName was wrong). So there seem to be a few path issues with Framework inclusion left as TODOs for it to work.

@tadija I think you're the best person for fixing that issues without breaking the current logic. Would you mind having a look?

@tadija
Copy link
Owner

tadija commented May 21, 2016

Hi @Dschee, thanks for this temporary solution, I finally did this in 3.0.0.

@tadija tadija closed this May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants