Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Breaks other plugins as of 1.2.0 #2

Closed
xamionex opened this issue Dec 16, 2023 · 4 comments
Closed

[Bug] Breaks other plugins as of 1.2.0 #2

xamionex opened this issue Dec 16, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@xamionex
Copy link

xamionex commented Dec 16, 2023

As of NiceChat 1.2.0 it breaks MoreCompany's cosmetics, and gives a bunch of other exceptions for the hud
1.1.0.log: Everything works as expected
1.2.0.log: MC doesn't load cosmetics, and exceptions for other mods, I'm pretty sure L682 and L1261 is at fault

Reason for the two logs is so that you can differentiate if something is an issue with your mod
Here's a diff checker page with them compared

This is my r2modman code: 018c718d-fbdd-aa01-3d71-a3f794de449a

Let me know if you want me to test something for you/see if changing/disabling something fixes it

@xamionex
Copy link
Author

Still an issue in 1.2.1 unfortunately
You should test with 3rdperson mod because it shows the cosmetics if you enable them in the settings:
NiceChat Disabled:
image
NiceChat 1.2.1:
image

@xamionex
Copy link
Author

xamionex commented Dec 18, 2023

Mod profile for testing if needed: 018c7bc8-263d-9c10-d23e-782199705ded
Mod List:

NiceChat by taffyko
inacraft_cosmetics_megapack by broiiler
MoreCompany by notnotnotswipez
BepInExPack by BepInEx
3rdPerson by Verity

Enable MoreCompany cosmetics support in verity.3rdperson.cfg and you can see cosmetics when it works

@taffyko
Copy link
Owner

taffyko commented Dec 19, 2023

thank you for all the details and reproduction steps! — i'm working on a fix!

@taffyko
Copy link
Owner

taffyko commented Dec 19, 2023

alright, 1.2.2 released, things should be fixed now
— thanks again for the high-quality report, feel free to open a new ticket if you have any more issues!

@taffyko taffyko closed this as completed Dec 19, 2023
@taffyko taffyko added the bug Something isn't working label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants