Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle multiple <PropertyGroup> tags #8

Closed
mmedic opened this issue Mar 28, 2018 · 1 comment
Closed

Does not handle multiple <PropertyGroup> tags #8

mmedic opened this issue Mar 28, 2018 · 1 comment
Assignees
Labels

Comments

@mmedic
Copy link

mmedic commented Mar 28, 2018

If csproj file has multiple <PropertyGroup> tags and any of them but first have the <Version> tag, the tool will not detect it and instead will create a new <Version> tag inside of the first <PropertyGroup> tag even though a subsequent <PropertyGroup> tag already has a <Version> tag set. For example:

<PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<PropertyGroup>
    <Version>123</Version>
</PropertyGroup>

In above example, the tool will create a new <Version> tag inside of the first <PropertyGroup> tag instead of updating the <Version> tag inside of the second <PropertyGroup> tag.

TAGC added a commit that referenced this issue Mar 28, 2018
@TAGC TAGC self-assigned this Mar 28, 2018
@TAGC TAGC added the bug label Mar 28, 2018
TAGC added a commit that referenced this issue Mar 28, 2018
@TAGC
Copy link
Owner

TAGC commented Mar 29, 2018

Thanks for pointing this out. I think I've fixed this and I'll release an update shortly.

@TAGC TAGC closed this as completed Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants