Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows specific macro checks #86

Closed
bodand opened this issue Oct 2, 2019 · 0 comments
Closed

Fix Windows specific macro checks #86

bodand opened this issue Oct 2, 2019 · 0 comments

Comments

@bodand
Copy link
Contributor

bodand commented Oct 2, 2019

The Windows macro checks check for _WINDOWS to be defined, however, as I checked it is not defined on any compiler I have installed (GCC 9.2; clang 8.0.1; MSVC 19.21.27702.2) that can target Windows. It is not even mentioned on MSDN.
To note, my setup couldn't compile the program as is; it thought I was on something non-windows, and tried to include <termios.h>.

Momentarily, I can do a pull request, to patch this, if it's alright.

Appendix
GCC & clang check:
pwsh_V97Zrm5qMv
MSVC check:
cmd_0XQp9nX0fZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants