Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WITH clause support for Presto #28

Closed
achiku opened this issue Mar 7, 2015 · 4 comments
Closed

WITH clause support for Presto #28

achiku opened this issue Mar 7, 2015 · 4 comments

Comments

@achiku
Copy link
Contributor

achiku commented Mar 7, 2015

Is it ok to loosen query validation a bit to allow WITH clause?

We are extensively using shib to query Presto, and as our query gets more and more complex, we would want to use WITH clause to simplify how query looks.

WITH clasuse for Presto

If you have any concern, please let me know. If you are ok with this idea, I will send p-r for this.
@achiku achiku mentioned this issue Mar 7, 2015
Closed
@tagomoris
Copy link
Owner

It seems good for me. Please send me p-r :-)

@achiku
Copy link
Contributor Author

achiku commented Mar 7, 2015

Cool. I'll send p-r as soon as it's ready.

@achiku
Copy link
Contributor Author

achiku commented Mar 8, 2015

I created p-r for this issue.
#30

@tagomoris
Copy link
Owner

#30 merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tagomoris @achiku