Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-folder run doesn't exit on listen error #67

Closed
meejah opened this issue Apr 4, 2020 · 3 comments
Closed

magic-folder run doesn't exit on listen error #67

meejah opened this issue Apr 4, 2020 · 3 comments

Comments

@meejah
Copy link
Collaborator

meejah commented Apr 4, 2020

If the magic-folder daemon fails to listen on its web-port, an exception is printed but the program keeps running (and logs "successful startup"). Magic-folder should exit if this fails.

(Also, I'm not sure that the --web-port should be optional? It currently defaults to tcp:9889. Maybe a better default would be "whatever is in magic-folder.url if that file exists in the node-dir" or just not having a default at all (i.e. it's a required option).

@exarkun
Copy link
Member

exarkun commented Apr 15, 2020

(Also, I'm not sure that the --web-port should be optional? It currently defaults to tcp:9889. Maybe a better default would be "whatever is in magic-folder.url if that file exists in the node-dir" or just not having a default at all (i.e. it's a required option).

I wouldn't object to removing the default value. Perhaps file a separate ticket for that part though.

@meejah
Copy link
Collaborator Author

meejah commented Apr 15, 2020

Okay, filed a ticket for the second part.

@meejah
Copy link
Collaborator Author

meejah commented Jan 28, 2022

Implemented

@meejah meejah closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants