-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magic-folder run
doesn't exit on listen error
#67
Comments
I wouldn't object to removing the default value. Perhaps file a separate ticket for that part though. |
Okay, filed a ticket for the second part. |
Implemented |
If the magic-folder daemon fails to listen on its web-port, an exception is printed but the program keeps running (and logs "successful startup"). Magic-folder should exit if this fails.
(Also, I'm not sure that the
--web-port
should be optional? It currently defaults totcp:9889
. Maybe a better default would be "whatever is inmagic-folder.url
if that file exists in the node-dir" or just not having a default at all (i.e. it's a required option).The text was updated successfully, but these errors were encountered: