Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval tx breaks swap flow #2302

Open
3 tasks
mhluongo opened this issue Sep 26, 2022 · 2 comments
Open
3 tasks

Approval tx breaks swap flow #2302

mhluongo opened this issue Sep 26, 2022 · 2 comments
Assignees
@jagodarybacka
Labels
Priority: Medium Medium monetary / growth impact, long time frame for completion Type: Bug Something isn't working
Milestone
Polish

Comments

@mhluongo
Copy link
Contributor

To reproduce:

  • Swap an unapproved ERC-20
  • Approve the ERC-20
  • Instead of the "Get final quote" button showing, the asset amounts will be cleared out :(

Screenshot from 2022-09-26 13-17-12
Screenshot from 2022-09-26 13-17-46
@mhluongo mhluongo added Type: Bug Something isn't working Priority: Medium Medium monetary / growth impact, long time frame for completion labels Sep 26, 2022
@0xDaedalus 0xDaedalus added this to the Polish milestone Oct 3, 2022
@jagodarybacka
Copy link
Contributor

I cannot reproduce this issue. Checked both ETH and L2s. Seems to work as expected on the current main. Feel free to reopen if you still see this problem.

Screen.Recording.2022-11-08.at.13.10.55.mov

@michalinacienciala
Copy link
Contributor

I'm reopening. I'm experiencing this problem on fresh install of extension-builds-3652. I'm experiencing either this or #3656 issue. I've tested on multiple networks and never got a correct behavior.

Video:
https://github.com/tahowallet/extension/assets/78352137/6d922583-34eb-4a27-8967-68fd97fdb3ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagodarybacka jagodarybacka

Labels
Priority: Medium Medium monetary / growth impact, long time frame for completion Type: Bug Something isn't working
Projects
None yet
Milestone
Polish
Development

No branches or pull requests
4 participants
@mhluongo @jagodarybacka @michalinacienciala @0xDaedalus