Remove onClick triggering onGestureStart in Control component #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the onClick event fire the onGestureStart handler leads to unexpected behaviour. When just clicking the knob without moving the mouse in between, onGestureStart gets fired twice and onGestureEnd only once. I'd suggest removing the onClick to get the expected result, unless there is some other reason to keep it i am not aware of?