Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the implementation of IdentifyValuesUsedInOtherOffloads #3467

Closed
strongoier opened this issue Nov 11, 2021 · 0 comments · Fixed by #3597
Closed

Finish the implementation of IdentifyValuesUsedInOtherOffloads #3467

strongoier opened this issue Nov 11, 2021 · 0 comments · Fixed by #3597
Labels
bug We've confirmed that this is an BUG ir IR related issues welcome contribution

Comments

@strongoier
Copy link
Contributor

The implementation of IdentifyValuesUsedInOtherOffloads is not finished yet:

// Traverse offloaded blocks to identify out-of-offload local LD/ST and
// statement references
class IdentifyValuesUsedInOtherOffloads : public BasicStmtVisitor {
using BasicStmtVisitor::visit;

More specifically, most statements currently go through:

void visit(Stmt *stmt) override {
int n_op = stmt->num_operands();
for (int i = 0; i < n_op; i++) {
auto op = stmt->operand(i);
test_and_allocate(op);
}
}

However, the operands involved in many of them are not present at the operands member variable, therefore they will not be handled. #3463 is an example of a result bug and #3466 is an example of the corresponding fix.

To avoid future appearance of such bugs, we need to finish the implementation of this class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We've confirmed that this is an BUG ir IR related issues welcome contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant