Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is still skipped when there are non-doc modifications #3568

Closed
strongoier opened this issue Nov 20, 2021 · 1 comment
Closed

CI is still skipped when there are non-doc modifications #3568

strongoier opened this issue Nov 20, 2021 · 1 comment
Labels
ci potential bug Something that looks like a bug but not yet confirmed welcome contribution

Comments

@strongoier
Copy link
Contributor

https://github.com/taichi-dev/taichi/runs/4252103913?check_suite_focus=true is an example run. Although docs/lang/articles/basic/type.md is modified, there are other non-doc modifications. However, CI is skipped in this case.

The logic here:

if [[ $file == docs/* ]]; then
echo "This modified file is not under the 'docs' folder."
echo "::set-output name=run_job::false"
break

is incorrect. We can skip CI only if all modifications are within docs.

@strongoier strongoier added potential bug Something that looks like a bug but not yet confirmed ci welcome contribution labels Nov 20, 2021
@strongoier
Copy link
Contributor Author

Fixed by #3569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci potential bug Something that looks like a bug but not yet confirmed welcome contribution
Projects
None yet
Development

No branches or pull requests

1 participant