Avoid duplicate evaluations in chaining comparison #540
Conversation
…umber of args (taichi-dev#534) * Make sure KernelTemplateMapper extractors's size is the same as the number of args Fixes taichi-dev#531 * fix test
|
|
||
| @ti.kernel | ||
| def func(): | ||
| a[2] = 0 <= ti.append(a.parent(), [], 10) < 1 |
There was a problem hiding this comment.
I would break the test into multiple pieces.
a[2] = 0 <= ti.append(a.parent(), [], 10) < 1itself can be considered as one test (test_no_duplicate_eval).a[3] = b < c == dtoc == d != b < d > b >= b <= c(test_chain_compare)- It is also worth testing all 6 ops independently, so that every line of your code written is covered. (
test_compare_basics) - Also test the difference between, say,
<and<=. (test_compare_equality)
|
CI fails at some tests which seem not my fault? |
Please do not apply the AST transformer (all transforms including |
|
|
|
Yeah now it may be throwing a different kind of exception. Please update |
|
Now it successfully finished without throwing any exceptions. |
|
I see. Please disallow |
|
How can I know if the scope is Taichi-scope in expr.py? |
|
|
Related issue id = #327