Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 - Stackblitz and Taiga UI v3.0 #2541

Closed
2 of 9 tasks
nsbarsukov opened this issue Aug 31, 2022 · 3 comments 路 Fixed by #2636 or #2747
Closed
2 of 9 tasks

馃悶 - Stackblitz and Taiga UI v3.0 #2541

nsbarsukov opened this issue Aug 31, 2022 · 3 comments 路 Fixed by #2636 or #2747
Assignees
Labels
bug Something isn't working P2 This issue has medium priority

Comments

@nsbarsukov
Copy link
Member

Which @taiga-ui/* package(s) are the source of the bug?

Don't known / other

Please provide a link to a minimal reproduction of the bug

See description

Is this issue blocking you?

Non-Blocking

Description

  1. Make stackblitz great again for v3.x
  2. After fixing this issue Fix version switcher between 2.x and 3.x聽#2533 , user will be able to open different major-versions of demo-application. If user opens stackblitz from v2.0 demo-application => open stackblitz with latest 2.x.x.

Angular version

any

Taiga UI version

3.0.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@nsbarsukov nsbarsukov added bug Something isn't working P2 This issue has medium priority labels Aug 31, 2022
@nsbarsukov nsbarsukov self-assigned this Aug 31, 2022
@nsbarsukov
Copy link
Member Author

Unfortunately, it is impossible to run Stackblitz with Taiga 3.0 :(

Taiga UI 3.0 is Ivy-distributed library. Ivy-distributed library is incompatible with View Engine apps.
Taiga UI 3.0 can be used only inside Ivy-app.

Stackblitz can launch Angular Ivy app.
But Stackblitz fails to run ngcc (just reminder, ngcc is a way to compile View Engine libraries so that Ivy applications can consume them).

See this issue stackblitz/core#1364

Is it a problem ? Do we have any View Engine deps ?
Unfortunately, @taiga-ui/kit depends on Angular View Engine library angular2-text-mask.
This library is no longer maintained and no chance that it will be published with Ivy-distrubition.

See my minimum reproduction of the problem:
https://stackblitz.com/edit/ng12-with-view-engine-dep?file=src/app/app.component.ts
In this example build fails with error:

Error in ~/src/main.ts
ngcc failed to run on angular2-text-mask@9.0.0.

@nsbarsukov
Copy link
Member Author

We already have plans to use new mask for our components (or maybe even develop our own mask library).
See this issue #120

After replacing our legacy mask with new one, we will be able to fix this issue.

@nsbarsukov
Copy link
Member Author

nsbarsukov commented Sep 5, 2022

Another possible temporary "solution" 鈥撀爓e can copy-paste this file from angular2TextMask-library.
Then replace angular2TextMask-dep with text-mask-core (vanilla-js library).

This temporary hack can fix stackblitz.

P.S. we should discourage our users to use this copy-pasted temporary directive (we are going to drop it as soon as possible). We can initially mark it as @deprecated (most IDE will display it as strikethrough text).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 This issue has medium priority
1 participant