Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about non-existing feature '' if --skip '' is specified #163

Closed
Nemo157 opened this issue Sep 4, 2022 · 1 comment · Fixed by #164
Closed

Warning about non-existing feature '' if --skip '' is specified #163

Nemo157 opened this issue Sep 4, 2022 · 1 comment · Fixed by #164
Labels
C-enhancement Category: A new feature or an improvement for an existing one

Comments

@Nemo157
Copy link

Nemo157 commented Sep 4, 2022

I'm setting up some reusable workflows for my projects and as part of that need to pass in a parameterized --skip flag. Previously on 0.3.9 having this empty for projects that don't need to skip any features worked without any warnings, now on 0.5.17 this outputs a warning:

> cargo hack check --feature-powerset --skip ''
warning: specified feature `` not found in package `self-test`
info: running `cargo check --no-default-features` on self-test (1/1)
    Finished dev [unoptimized + debuginfo] target(s) in 0.00s

It would be nice if an empty string was considered the same as not passing the flag.

@Nemo157 Nemo157 changed the title Warning about non-existing feature ` if --skip ''` is specified Warning about non-existing feature '' if --skip '' is specified Sep 4, 2022
@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Sep 4, 2022
@bors bors bot closed this as completed in f4c9d50 Sep 4, 2022
@taiki-e
Copy link
Owner

taiki-e commented Sep 4, 2022

Fixed in 0.5.18 (#164). Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants