You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the implementation of coverage_helper replaces std::test with coverage_helper::test. However, this approach doesn't work for tokio::test. Given that tokio::test is widely used, shall we support tokio::test in this crate?
IMO, we can provide a tokio module in coverage_helper, like:
mod test{use coverage_helper::{tokio, test};#[test]fntest_foo(){...}#[tokio::test]asyncfntest_bar(){...}}
What do you think? If this approach is feasible, I can do some contributions.
The text was updated successfully, but these errors were encountered:
As said in taiki-e/cargo-llvm-cov#273, tokio::test refers ::core::prelude::v1::test, so it's not working with coverage_helper.
The most desirable fix is to change libtest so that the test attribute gets no_coverage, and the second most desirable is to make the change on the tokio side.
Hi, @taiki-e.
Currently, the implementation of coverage_helper replaces
std::test
withcoverage_helper::test
. However, this approach doesn't work fortokio::test
. Given thattokio::test
is widely used, shall we supporttokio::test
in this crate?IMO, we can provide a
tokio
module incoverage_helper
, like:What do you think? If this approach is feasible, I can do some contributions.
The text was updated successfully, but these errors were encountered: