Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include markdown file as PDF format in assets #12

Closed
xudesheng opened this issue Mar 6, 2022 · 8 comments · Fixed by #17
Closed

include markdown file as PDF format in assets #12

xudesheng opened this issue Mar 6, 2022 · 8 comments · Fixed by #17
Labels
enhancement New feature or request

Comments

@xudesheng
Copy link

Is there a way to upload a markdown file in pdf format separately or in the zip/tar file with bin together?

@taiki-e
Copy link
Owner

taiki-e commented Mar 18, 2022

It would definitely make sense to add the ability to upload other files in the same archive or separately. (Related: #2, #1)

I'm not sure if markdown to PDF conversion should belong to this project, but I think once the above functionality is implemented, it will be easily available in combination with external commands or other Github action.

- run: ... # external command to convert README.md to PDF and save as README.pdf
- uses: taiki-e/create-gh-release-action@v1
  with:
    # files to include in archive
    include: README.pdf
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@taiki-e taiki-e added the enhancement New feature or request label Mar 18, 2022
@Hunlongyu
Copy link

Can't use include yet? I added this attribute, but it didn't take effect, and there was an warn.
image

image

@Hunlongyu
Copy link

Or can I not compress the program on Windows platform。

I want get xx.exe not xx.zip

@taiki-e
Copy link
Owner

taiki-e commented Jul 5, 2022

The basic implementation of include input option is in #17.

Or can I not compress the program on Windows platform。

I want get xx.exe not xx.zip

#6 is a tracker for this.

@Hunlongyu
Copy link

Hunlongyu commented Jul 6, 2022

my dir
image

I try these:

with:
  bin: electron-icon-builder

  include:electron-icon-builder.exe
or
  include: target/release/electron-icon-builder.exe
or
  include: /target/release/electron-icon-builder.exe
or
  include: README.md

image

I can't get electron-icon-builder.exe or README.md

How can I write code to get the electron-icon-builder.exe file and upload it to release correctly.

My github actions workfows release.yml, link

@taiki-e
Copy link
Owner

taiki-e commented Jul 6, 2022

I can't get electron-icon-builder.exe or README.md

I believe both are included in the zip file (electron-icon-builder-x86_64-pc-windows-msvc.zip).

As mentioned above, uploading with no archive is not yet supported and is tracked in issue #6.

@Hunlongyu
Copy link

emmmm......

image

I got README.md in zip

But I want get this:
image

Because I don't want to compress exe files

@taiki-e
Copy link
Owner

taiki-e commented Jul 7, 2022

@Hunlongyu As of 1.7.0 (#23), the following should work.

      - uses: taiki-e/upload-rust-binary-action@v1
        with:
          bin: electron-icon-builder
          asset: README.md,target/release/electron-icon-builder.exe
          zip: none
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       if: matrix.os == 'windows-latest'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants