Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CICD workflows #204

Closed
1 task done
d1onys1us opened this issue May 14, 2024 · 1 comment · Fixed by #224
Closed
1 task done

Fix CICD workflows #204

d1onys1us opened this issue May 14, 2024 · 1 comment · Fixed by #224
Assignees

Comments

@d1onys1us
Copy link
Collaborator

Describe the feature request

I opened a PR for just a .yml workflow, and it triggered all the SGX, etc. builds which I think take forever. We should only run those when we need to run those.

Ideally we should trigger a build when:

  • Those files changes
  • The cargo.toml of any shared dependencies gets updated (dependabot)

Otherwise we should skip.

Can someone help me make a mapping of folderPathOfFilesChanges -> workflowNeedsToRun?

Spam policy

  • I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.
@Brechtpd
Copy link
Contributor

Brechtpd commented May 14, 2024

I think something like this:

  • host, lib, primitives, script -> all
  • docker -> SGX docker test
  • pipeline, harness -> all zkVMs
  • provers/sgx -> all sgx tests (including docker one)
  • provers/sp1 -> sp1 tests
  • provers/risc -> risc0 tests
  • provers/powdr -> nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants