fix(tests): cleanup tests to prepare for tokenomics testing #11316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tempting tokenomics tests, as code will largely need to be re-used.
Codecov Report
@@ Coverage Diff @@
## main #11316 +/- ##
==========================================
- Coverage 67.79% 66.41% -1.38%
==========================================
Files 109 113 +4
Lines 2937 3034 +97
Branches 354 356 +2
==========================================
+ Hits 1991 2015 +24
- Misses 869 943 +74
+ Partials 77 76 -1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…utils to regular utils folders, reusabel deploy functions for taikol1 and taikol2
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dantaik
requested changes
Jan 7, 2023
d1onys1us
reviewed
Jan 10, 2023
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
|
@cyberhorsey is this ready for review? (just in case you forgot to change the status) |
dantaik
approved these changes
Jan 14, 2023
davidtaikocha
approved these changes
Jan 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed for Tokenomcis testing I will need to reuse a lit of functionality. Started to cleanup TaikoL1 tests but also moved on to Bridge as they seemed the messiest so far.
Decided to separate integration tests into their own files.
Did a bunch of scaffolding for tokenomics testing, like creating a proposer class we can reuse, and started on proving but it isn't finished yet.
Added a new config option for whether TaikoL2 should check public inputs, so I can call anchor successfully.