fix(status-page): gas price should use l2provider, add descriptions and tooltips #12490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
requested review from
davidtaikocha,
d1onys1us,
shadab-taiko and
RogerLamTd
|
Not sure if this is intentional or coincidental, it looks like gas price is truncated to 1 decimal at the moment? |
cyberhorsey
changed the title
I dont think it is truncated, I think thats the current value |
RogerLamTd
previously approved these changes
Jan 10, 2023
d1onys1us
reviewed
Jan 10, 2023
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
d1onys1us
previously approved these changes
Jan 10, 2023
RogerLamTd
reviewed
Jan 11, 2023
RogerLamTd
reviewed
Jan 11, 2023
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
RogerLamTd
approved these changes
Jan 11, 2023
mfinestone
approved these changes
Jan 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.