Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-ui): bridge light and dark themes #12957

Merged
merged 17 commits into from
Jan 19, 2023
Merged

feat(bridge-ui): bridge light and dark themes #12957

merged 17 commits into from
Jan 19, 2023

Conversation

shadab-taiko
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #12957 (204f6bf) into main (dd389be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12957   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files         113      113           
  Lines        3050     3050           
  Branches      357      357           
=======================================
  Hits         2023     2023           
  Misses        951      951           
  Partials       76       76           
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø)
protocol 59.23% <ø> (ø) Carriedforward from 0b26323
relayer 68.92% <ø> (ø) Carriedforward from 0b26323
ui 100.00% <ø> (ø) Carriedforward from 0b26323

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d1onys1us
Copy link
Contributor

@shadab-taiko is this pending any changes? Such as an update to a light theme of the banner? My current critiques are:

  • light theme banner would be better
  • i think tailwind neutral > gray? for example the connect wallet button goes between two "dark palettes", in dark mode it is the more neutral gray (called neutral in tailwind), and in light mode it is the gray with the slightly blue tint.
  • i think the border is a bit strong / dark for the light theme.
  • i still think we can try to maybe lighten the buttons just one 100 shade on tailwind.

otherwise looks great! let me know when you need a re-review.

@shadab-taiko
Copy link
Contributor Author

@d1onys1us since we don't currently have a lighter version of the banner image we will have to go ahead with this and wait till we have some design help on this.

Made the border and buttons lighter, let me know what you think.

@shadab-taiko shadab-taiko changed the title feat(bridge): bridge light and dark themes feat(bridge-ui): bridge light and dark themes Jan 18, 2023
@cyberhorsey cyberhorsey enabled auto-merge (squash) January 18, 2023 18:23
@cyberhorsey cyberhorsey merged commit a36aebd into main Jan 19, 2023
@cyberhorsey cyberhorsey deleted the bridge-theme branch January 19, 2023 04:18
@github-actions github-actions bot mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants